More interpolation types in Tabular.#3413
Conversation
GuySten
force-pushed
the
tabular
branch
2 times, most recently
from
332056f to
1f7d62c
Compare
remove unused function
|
While working through the open PRs I just noticed that a conflict has crept into this one |
|
I fixed the conflicts. |
paulromano
left a comment
paulromano
left a comment
There was a problem hiding this comment.
Thanks for putting this together @GuySten and sorry it has taken me a long time to look this one over. In general, I feel like the addition of the Lambert W function on the C++ side is a lot of code for something that would almost never be used. I would be comfortable adding the sampling routines on the Python side (where we already have access to lambertw from scipy) but would prefer not to include the C++ portion. If someone really needs to sample a lin-log distribution on the C++ side, I think a better option is to just linearize it first and we already have the openmc.data.grid.linearize function that can handle that.
|
I removed lin log interpolation from cpp side. |
3 participants
Description
This pull request implement more interpolation types in Tabular by using inverse transform sampling algorithm.
Fixes #2409.
Fixes #3722.
Checklist